Fix "Init script starts iodined even if it is already running"

by removing the "--pidfile" option from the start-stop-daemon calls;
doesn't work for a forking process. Thanks to Michael Goetzefor the bug
report (closes: #511887).

diff --git a/debian/changelog b/debian/changelog
index fb7ab11c98482d72384b4b8c58731f909d2212e7..6aec89e4602ebdd88db43f2e692be5351a14a076 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,10 @@
 iodine (0.4.2-3) UNRELEASED; urgency=low
 
   * Add Swedish debconf translation, thanks to Martin Bagge (closes: #504247).
+  * Fix "Init script starts iodined even if it is already running"
+    by removing the "--pidfile" option from the start-stop-daemon calls;
+    doesn't work for a forking process. Thanks to Michael Goetzefor the bug
+    report (closes: #511887).
 
  -- gregor herrmann <gregoa@debian.org>  Sun, 02 Nov 2008 13:56:18 +0100
 

diff --git a/debian/iodine.iodined.init b/debian/iodine.iodined.init
index a7227ec686e195f0c96e88d1e0b898578a57cca8..35fec0878bce35042118d8053593ac045808acfe 100644 (file)
--- a/debian/iodine.iodined.init
+++ b/debian/iodine.iodined.init
@@ -63,9 +63,9 @@ do_start()
        #   0 if daemon has been started
        #   1 if daemon was already running
        #   2 if daemon could not be started
-       start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON --test > /dev/null \
+       start-stop-daemon --start --quiet --exec $DAEMON --test > /dev/null \
                || return 1
-       start-stop-daemon --start --quiet --pidfile $PIDFILE --exec $DAEMON -- \
+       start-stop-daemon --start --quiet --exec $DAEMON -- \
                $DAEMON_ARGS \
                || return 2
        # Add code here, if necessary, that waits for the process to be ready
@@ -83,7 +83,7 @@ do_stop()
        #   1 if daemon was already stopped
        #   2 if daemon could not be stopped
        #   other if a failure occurred
-       start-stop-daemon --stop --quiet --retry=TERM/5/KILL/5 --pidfile $PIDFILE --name $NAME
+       start-stop-daemon --stop --quiet --retry=TERM/5/KILL/5 --name $NAME
        RETVAL="$?"
        [ "$RETVAL" = 2 ] && return 2
        # Wait for children to finish too if this is a daemon that forks