New patch uninitialized-inside_topdomain.patch: initialize
authorgregor herrmann <gregoa@debian.org>
Mon, 20 Sep 2010 21:23:49 +0000 (21:23 -0000)
committergregor herrmann <gregoa@debian.org>
Mon, 20 Sep 2010 21:23:49 +0000 (21:23 -0000)
inside_topdomain before using it; thanks to Samuel Thibault for the bug
report and the patch (closes: #596740).

debian/changelog
debian/patches/series
debian/patches/uninitialized-inside_topdomain.patch [new file with mode: 0644]

index 5901425f4daa5e6183b66ecf840da691daa41a47..2756691c94b98ce65c264a1d966f5559cbcaec44 100644 (file)
@@ -2,6 +2,9 @@ iodine (0.6.0~rc1-3) UNRELEASED; urgency=low
 
   * Build with hardening; thanks to Romain Francoise for the bug report and
     the patch (closes: #589054).
+  * New patch uninitialized-inside_topdomain.patch: initialize
+    inside_topdomain before using it; thanks to Samuel Thibault for the bug
+    report and the patch (closes: #596740).
   * Set Standards-Version to 3.9.1 (no changes).
 
  -- gregor herrmann <gregoa@debian.org>  Sun, 22 Aug 2010 00:17:11 +0200
index df21f990f4ada0049642caee848348ee861e4e5f..16bc9285e06c9b5c2a322e7adcbd887a946e8112 100644 (file)
@@ -1,3 +1,4 @@
 03_cflags.patch
 spelling.patch
 manpage.patch
+uninitialized-inside_topdomain.patch
diff --git a/debian/patches/uninitialized-inside_topdomain.patch b/debian/patches/uninitialized-inside_topdomain.patch
new file mode 100644 (file)
index 0000000..b193356
--- /dev/null
@@ -0,0 +1,20 @@
+Description: fix an uninitialized variable: 
+ when domain_len < 0 for instance, inside_topdomain is not initialized, but used.
+Origin: vendor
+Bug: http://bugs.debian.org/596740
+Forwarded: yes
+Author: Samuel Thibault <sthibault@debian.org>
+Reviewed-by: gregor herrmann <gregoa@debian.org>
+Last-Update: 2010-09-20
+
+--- a/src/iodined.c
++++ b/src/iodined.c
+@@ -1567,7 +1567,7 @@
+       struct query q;
+       int read;
+       int domain_len;
+-      int inside_topdomain;
++      int inside_topdomain = 0;
+       if ((read = read_dns(dns_fd, tun_fd, &q)) <= 0)
+               return 0;