The line width is checked now.

[philipp/winterrodeln/mediawiki_extensions/wrmap.git] / wrmap.body.php

diff --git a/wrmap.body.php b/wrmap.body.php
index b4671c00438e071ebc7f559904186f5f5d994c32..753d5cd3d263846ddeb3a43f62c84a2f491d9058 100644 (file)
--- a/wrmap.body.php
+++ b/wrmap.body.php
@@ -74,7 +74,12 @@ function xml_to_json_features($input) {
                        $wrong_properties = array_diff($given_properties, $allowed_properties);
                        if (count($wrong_properties) > 0) throw new Exception("Das Attribut '" . reset($wrong_properties) . "' ist nicht erlaubt bei <" . $feature->getName() . ">. Erlaubt sind: '" . implode("', '", $allowed_properties) . "'.");
                        foreach ($given_properties as $property) {
-                               $properties[$property] = (string) $feature[$property];
+                               $propval = (string) $feature[$property];
+                               if ($property == 'wiki') {
+                                       $title = Title::newFromText($propval);
+                                       $propval = $title->getLocalUrl();
+                               }
+                               $properties[$property] = $propval;
                        }
                        $coordinates = geo_to_coordinates($feature);
                        if (count($coordinates) != 1) throw new Exception('Das Element <' . $feature->getName() . '> muss genau ein Koordinatenpaar haben.');
@@ -94,8 +99,18 @@ function xml_to_json_features($input) {
                        $allowed_properties = array('farbe', 'dicke');
                        $wrong_properties = array_diff($given_properties, $allowed_properties);
                        if (count($wrong_properties) > 0) throw new Exception("Das Attribut '" . reset($wrong_properties) . "' ist nicht erlaubt bei <" . $feature->getName() . ">. Erlaubt sind: '" . implode("', '", $allowed_properties) . "'.");
-                       if (isset($feature['farbe'])) $properties['strokeColor'] = (string) $feature['farbe']; // e.g. #a200b7 // TODO: Check
-                       if (isset($feature['dicke'])) $properties['strokeWidth'] = (int) $feature['dicke']; // e.g. 6 // TODO: Check
+                       if (isset($feature['farbe'])) {
+                               $color = (string) $feature['farbe']; // e.g. #a200b7
+                               if (preg_match('/^#[0-9a-f]{6}$/i', $color) != 1) 
+                                       throw new Exception('Die Farbangabe der Linie hat ein falsches Format. Sie muss z.B. so aussehen: #a200b7.');
+                               $properties['strokeColor'] = $color;
+                       }
+                       if (isset($feature['dicke'])) {
+                               $stroke_width = (int) $feature['dicke']; // e.g. 6
+                               if (((string) $stroke_width) !== (string) $feature['dicke'])
+                                       throw new Exception('Die Angabe der Liniendicke hat ein falsches Format. Sie muss eine ganze Zahl wie z.B. 6 sein.');
+                               $properties['strokeWidth'] = $stroke_width;
+                       }
                        $json_feature = array(
                                'type' => 'feature',
                                'geometry' => array(
@@ -162,8 +177,8 @@ class WrBaseMap {
 
                // Create <div/> element where the map is placed in
                global $wgExtensionAssetsPath;
-               $width_s = (isset($properties['width'])) ? $width . 'px' : '100%';
-               $height_s = (isset($properties['height']) ? $height : 450) . 'px';
+               $width_s = (isset($properties['width'])) ? (string) $properties['width'] . 'px' : '100%';
+               $height_s = (isset($properties['height']) ? (string) $properties['height'] : 450) . 'px';
                $output = "<div class=\"wrmap\" style=\"width: $width_s; height: $height_s; border-style:none;\" data-img-path=\"$wgExtensionAssetsPath/wrmap/openlayers/img/\">";
                $output .= "<script type=\"application/json\">";
                $output .= htmlspecialchars($json_string, ENT_NOQUOTES);