apply patch from Bug 32501 - [QuestyCaptcha] Help page is broken
authorMark A. Hershberger <mah@users.mediawiki.org>
Thu, 1 Dec 2011 16:24:49 +0000 (16:24 +0000)
committerMark A. Hershberger <mah@users.mediawiki.org>
Thu, 1 Dec 2011 16:24:49 +0000 (16:24 +0000)
Fixes:

  When trying to open the help page, the following messages appear:
<pre>
Notice: Undefined property: QuestyCaptcha::$storage in
/.../extensions/ConfirmEdit/QuestyCaptcha.class.php on line 68

Fatal error: Call to a member function cookiesNeeded() on a non-object in
/.../extensions/ConfirmEdit/QuestyCaptcha.class.php on line 68
</pre>

Might need to be merged so Extension Distributor can use it?

QuestyCaptcha.class.php

index 635277af513c15a85416849fa7286218c1cbf6bd..8e87db3051a26622b7f126b1941c08955cf1f80f 100644 (file)
@@ -65,7 +65,7 @@ class QuestyCaptcha extends SimpleCaptcha {
                global $wgOut;
                $wgOut->setPageTitle( wfMsg( 'captchahelp-title' ) );
                $wgOut->addWikiText( wfMsg( 'questycaptchahelp-text' ) );
-               if ( $this->storage->cookiesNeeded() ) {
+               if ( CaptchaStore::get()->cookiesNeeded() ) {
                        $wgOut->addWikiText( wfMsg( 'captchahelp-cookies-needed' ) );
                }
        }