From: gregor herrmann <gregoa@debian.org>
Date: Fri, 1 Jul 2016 12:58:29 +0000 (+0200)
Subject: play around with Popen until it works
X-Git-Url: https://git.toastfreeware.priv.at/toast/tdyndns.git/commitdiff_plain/47d25b57610e647a5f34e88f341ac3b4361f328b

play around with Popen until it works
---

diff --git a/bin/tdyndns_update b/bin/tdyndns_update
index b43286e..ea15832 100755
--- a/bin/tdyndns_update
+++ b/bin/tdyndns_update
@@ -51,9 +51,8 @@ def blockip_whitelist_add(ip):
 	"""
 	:param ip: ipv4 address
 	:raises a BlockipError in case of errors."""
-	command = "-I blockip -s {ip} -j ACCEPT\n\n".format(ip=ip)
-	p = Popen(['iptables'], stdin=PIPE)
-	p.communicate(command)
+	command = "iptables -I blockip -s {ip} -j ACCEPT".format(ip=ip)
+	p = Popen(command, shell=True)
 	if p.returncode != 0:
 		raise NsupdateError(p.returncode)
 
@@ -62,9 +61,8 @@ def blockip_whitelist_delete(ip):
 	"""
 	:param ip: ipv4 address
 	:raises a BlockipError in case of errors."""
-	command = "-D blockip -s {ip} -j ACCEPT\n\n".format(ip=ip)
-	p = Popen(['iptables'], stdin=PIPE)
-	p.communicate(command)
+	command = "iptables -D blockip -s {ip} -j ACCEPT".format(ip=ip)
+	p = Popen(command, shell=True)
 	if p.returncode != 0:
 		raise NsupdateError(p.returncode)