performance improvement for load persons

diff --git a/src/mvc/event.cpp b/src/mvc/event.cpp
index 4e19cb01e2177d6b63a085892f47d679b43f53b6..49ce16f6fea2e5fbaf02732ee885c7838f8b69fa 100644 (file)
--- a/src/mvc/event.cpp
+++ b/src/mvc/event.cpp
@@ -143,21 +143,23 @@ int Event::roomId() const
     return query.record().value("xid_room").toInt();
 }
 
-QStringList Event::persons() const
+QStringList Event::persons()
 {
-    QSqlQuery query;
-    // TODO: conference ID isn't used here
-    query.prepare("SELECT person.name FROM person INNER JOIN event_person ON person.id = event_person.xid_person AND event_person.xid_event = :id");
-    query.bindValue(":id", id());
-    query.exec();
-    // TODO: handle qeury error
-    //qDebug() << query.lastError();
-
-    QStringList persons;
-    while(query.next())
-        persons.append(query.record().value("name").toString());
+    if( personsList.isEmpty() )
+    {
+        QSqlQuery query;
+        // TODO: conference ID isn't used here
+        query.prepare("SELECT person.name FROM person INNER JOIN event_person ON person.id = event_person.xid_person AND event_person.xid_event = :id");
+        query.bindValue(":id", id());
+        query.exec();
+        // TODO: handle qeury error
+        //qDebug() << query.lastError();
+
+        while(query.next())
+            personsList.append(query.record().value("name").toString());
+    }
 
-    return persons;
+    return personsList;
 }
 
 QMap<QString,QString> Event::links() const

diff --git a/src/mvc/event.h b/src/mvc/event.h
index dccd970dbcc4d0a015dea42834cec86570cc7593..4fcd3ed4b04d0bdfa57d1de825b79959f56f8c31 100644 (file)
--- a/src/mvc/event.h
+++ b/src/mvc/event.h
@@ -65,7 +65,7 @@ public:
     // records from other tables associated with 'id'
     QString room() const;
     int roomId() const;
-    QStringList persons() const;
+    QStringList persons();
     QMap<QString,QString> links() const;
 
     void setId(int id) { setValue("id", id); }
@@ -88,6 +88,9 @@ public:
     void setLinks(const QMap<QString,QString> &aLinks);
 
 friend class EventTest;
+
+private:
+    QStringList personsList;
 };
 
 #endif // EVENT_H