Cleaning up some old PHP 4 object-reference usage in some edit filtering hooks.

There was a mix of uses of the reference and non-uses of the reference. :)
Reverts r53714 and fixes it from the other end by cleaning up the uses to not expect references.

diff --git a/ConfirmEdit_body.php b/ConfirmEdit_body.php
index faedc2f46d4f70c71ed1267b0e479467ad6f8ec2..8c0d78029426d17c9d4952da14096f077ce50131 100644 (file)
--- a/ConfirmEdit_body.php
+++ b/ConfirmEdit_body.php
@@ -23,7 +23,7 @@ class ConfirmEditHooks {
                return self::getInstance()->confirmEditMerged( $editPage, $newtext );
        }
 
                return self::getInstance()->confirmEditMerged( $editPage, $newtext );
        }
 

-       static function confirmEditAPI( &$editPage, $newtext, &$resultArr ) {
+       static function confirmEditAPI( $editPage, $newtext, &$resultArr ) {

                return self::getInstance()->confirmEditAPI( $editPage, $newtext, $resultArr );
        }
 
                return self::getInstance()->confirmEditAPI( $editPage, $newtext, $resultArr );
        }
 


@@ -509,7 +509,7 @@ class SimpleCaptcha {
        }
 
 
        }
 
 

-       function confirmEditAPI( &$editPage, $newtext, &$resultArr ) {
+       function confirmEditAPI( $editPage, $newtext, &$resultArr ) {

                if ( !$this->doConfirmEdit( $editPage, $newtext, false, false ) ) {
                        $this->addCaptchaAPI( $resultArr );
                        return false;
                if ( !$this->doConfirmEdit( $editPage, $newtext, false, false ) ) {
                        $this->addCaptchaAPI( $resultArr );
                        return false;